Don't run addruntimeassertion pass #125948
Open
+6
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125948
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 4 Unrelated FailuresAs of commit dacd91f with merge base 73ba432 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
tugsbayasgalan
added a commit
that referenced
this pull request
May 10, 2024
ghstack-source-id: 70faecaa5000836df108542464db8ae4ee9cad2e Pull Request resolved: #125948
[ghstack-poisoned]
tugsbayasgalan
requested review from
avikchaudhuri,
gmagogsfm and
zhxchen17
as code owners
tugsbayasgalan
added a commit
that referenced
this pull request
May 10, 2024
ghstack-source-id: 7845bbb759c36ffc937e2683498858f00799e25d Pull Request resolved: #125948
zhxchen17
requested changes
May 10, 2024
torch/fx/proxy.py
Outdated
| @@ -133,6 +133,9 @@ def create_node(self, kind : str, target : Target, | |||
| modification of values used in node creation. For example, one might | |||
| want to disallow in-place operations from being recorded. | |||
| """ | |||
|
|
|||
| if kind == "call_function" and "mul_2" in str(args): | |||
[ghstack-poisoned]
tugsbayasgalan
added a commit
that referenced
this pull request
May 10, 2024
ghstack-source-id: a582237002b2d276fb127b7cf8ee77e36dfad51b Pull Request resolved: #125948
zhxchen17
approved these changes
May 10, 2024
[ghstack-poisoned]
tugsbayasgalan
requested review from
BowenBao,
thiagocrepaldi and
wschin
as code owners
tugsbayasgalan
added a commit
that referenced
this pull request
May 10, 2024
ghstack-source-id: ffae77bac1c05b81682c166aa85e2d0768607566 Pull Request resolved: #125948
[ghstack-poisoned]
tugsbayasgalan
added a commit
that referenced
this pull request
May 10, 2024
ghstack-source-id: 77eaf64731925b94cf48a9b14c2e4dc63bb6f2a2 Pull Request resolved: #125948
[ghstack-poisoned]
tugsbayasgalan
added a commit
that referenced
this pull request
May 13, 2024
ghstack-source-id: a5ed904c1df49ba3b6506baf77128985659ad236 Pull Request resolved: #125948
|
@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Differential Revision: [D57630436](https://our.internmc.facebook.com/intern/diff/D57630436) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D57630436 |
tugsbayasgalan
added a commit
that referenced
this pull request
Jun 17, 2024
Pull Request resolved: #125948 @imported-using-ghimport Differential Revision: [D57630436](https://our.internmc.facebook.com/intern/diff/D57630436/) ghstack-source-id: 230467229
|
This pull request was exported from Phabricator. Differential Revision: D57630436 |
Differential Revision: [D57630436](https://our.internmc.facebook.com/intern/diff/D57630436) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D57630436 |
tugsbayasgalan
added a commit
that referenced
this pull request
Jun 17, 2024
Pull Request resolved: #125948 @imported-using-ghimport Differential Revision: [D57630436](https://our.internmc.facebook.com/intern/diff/D57630436/) ghstack-source-id: 230605372
Differential Revision: [D57630436](https://our.internmc.facebook.com/intern/diff/D57630436) [ghstack-poisoned]
tugsbayasgalan
added a commit
that referenced
this pull request
Jun 24, 2024
Pull Request resolved: #125948 @imported-using-ghimport Differential Revision: [D57630436](https://our.internmc.facebook.com/intern/diff/D57630436/) ghstack-source-id: 8cd3fb59cf5defd330b083c80fb4c6f0a5c9f9b3
|
@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Differential Revision: [D57630436](https://our.internmc.facebook.com/intern/diff/D57630436) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D57630436 |
tugsbayasgalan
added a commit
that referenced
this pull request
Jun 25, 2024
Pull Request resolved: #125948 @imported-using-ghimport Differential Revision: [D57630436](https://our.internmc.facebook.com/intern/diff/D57630436/) ghstack-source-id: 231536118
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D57630436
@diff-train-skip-merge